Update AWS SDK to V3 #15215
Merged
Update AWS SDK to V3 #15215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
approved these changes
Dec 20, 2024
samwho
approved these changes
Jan 6, 2025
packages/backend-core/src/objectStore/buckets/tests/app.spec.ts
Outdated
Show resolved
Hide resolved
packages/backend-core/src/objectStore/buckets/tests/global.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a while now we have needed to migrate from AWS SDK V2 to V3 - this is quite a big change with a lot of changing APIs, but luckily our usage of the AWS SDK is quite small.
I initially followed the guide here: https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/migrating.html and the tool it provides to start the migration off, however a lot of it did need to be done by hand as we make heavy use of presigned URLs and this is something that has changed quite a lot in the newer version.
The biggest difference is the fact that pre-signed URL generation is now an async function, previously this was a sync call and a lot of our call stack depended upon that - which is where the majority of the updates were required. I don't believe this is impactful from a performance point of view as the function is still doing the same work, but it is async incase the command you are pre-signing requires async work, which none of ours require.
Ignore the very large file difference, the majority of this comes from the
yarn.lockchanges required as AWS SDK V3 is broken down into lots of smaller packages rather than one gigantic one.